labath added a comment.
> How do we usually add tests for STL data structures?
I have https://reviews.llvm.org/D124155, which would allow testing of different
string layouts in one go. It remains to be seen how maintainable will that test
be when it starts supporting many string layouts. OTOH,
aprantl added a comment.
> How do we usually add tests for STL data structures?
I guess that matrix bot sort of covers this.
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126080/new
JDevlieghere added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126080/new/
https://reviews.llvm.org/D126080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
aprantl added a comment.
That seemed to have done the trick.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126080/new/
https://reviews.llvm.org/D126080
___
lldb-commits mailing list
lldb-commits@lists.ll
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf4570ce442b4: Adapt C++ std::string dataformatter for
D125496 (authored by aprantl).
Repository:
rG LLVM Github Monorep
aprantl added a comment.
I'm going to land this quickly to get the bots going again, but a thorough
review would still be very much appreciated!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126080/new/
https://reviews.llvm.org/D126080
___
l
aprantl created this revision.
aprantl added reviewers: ldionne, shafik, jingham.
aprantl added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
aprantl requested review of this revision.
https://reviews.llvm.org/D125496 changed the layout of std::string witho
