[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:136-156 llvm::StringRef value = v.GetValue(); llvm::StringRef summary = v.GetSummary(); llvm::StringRef type_name = v.GetType().GetDisplayTypeName(); + lldb::SBError error = v.GetError();

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

clayborg added a comment. In D126014#3886996 , @jgorbe wrote: > Hi! I've just debugged an issue that brought me to this commit. I'll start > preparing a patch tomorrow (not sure how to test it yet) but since it's a > recent-ish change I figured I'd ping

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

jgorbe added a comment. Hi! I've just debugged an issue that brought me to this commit. I'll start preparing a patch tomorrow (not sure how to test it yet) but since it's a recent-ish change I figured I'd ping the commit thread to give you a heads up. `v.GetSummary()` returns a char* that is ba

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fe220a33179: Show error message for optimized variables (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. A little background: we have people that end up debugging optimized code and when a variable's SBValue had an error, we wouldn't show anything in the variables window for the value. Repo

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, aadsm. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an issue t