This revision was automatically updated to reflect the committed changes.
Closed by commit rL246958: Use eAddressClassCode for address lookup for opcodes
for stack frames (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12556?vs=34038&id=34133#toc
Repository:
rL L
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We really do need to restrict this for single stepping purposes. If the thread
plans that single step and set breakpoints for stepping think they should place
a breakpoint on 0x1004 if the
If the user says "break set -a " I have no problem with our
setting the breakpoint there even if we don't think it is a terribly good idea.
But if lldb is converting any other specification to an address, it should
always move past data in text. The failure modes if you aren't careful about
t
tberghammer added a comment.
I agree that we want to enable it only in very special cases when the user
really know what he/she wants (probably pass in a --force flag). Anyway, it
isn't implemented with this change and I don't expect it to be implemented in
the near future.
http://reviews.llv
jingham added a subscriber: jingham.
jingham added a comment.
If the user says "break set -a " I have no problem with our
setting the breakpoint there even if we don't think it is a terribly good idea.
But if lldb is converting any other specification to an address, it should
always move past
tberghammer updated this revision to Diff 34038.
tberghammer added a comment.
Updated the change based on the comments.
I don't fully agree with restricting the user from setting breakpoint in
non-code locations because if LLDB classified a section incorrectly (e.g.
haven't found the SO file fo
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Did you check who is all calling this? Is it only places that know that an
address is code? It seems like we have might have different clients expecting
different things out of t
tberghammer retitled this revision from "Introduce new address class
eAddressClassDataIntermixedCode" to "Use eAddressClassCode for address lookup
for opcodes".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 33937.
tberghammer added a comment.
Addres
