[Lldb-commits] [PATCH] D125505: Cache tilde expansions to avoid redundant lookups

2022-05-12 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Yeah, you're right. And as I walk through in my head what I'm solving with this -- it's not the really expensive part of this whole operation, I don't think. I should check more carefully but it's the stat's over NFS partitions that are impacting performance, and

[Lldb-commits] [PATCH] D125505: Cache tilde expansions to avoid redundant lookups

2022-05-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't think the cache belongs in a global in the TildeExpressionResolver class. The derived ExpressionResolvers might very well resolve the same ~foo to different paths (e.g. if

[Lldb-commits] [PATCH] D125505: Cache tilde expansions to avoid redundant lookups

2022-05-12 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. We have tilde's in our dSYMs internally, and expanding these ca