[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

2022-05-09 Thread Greg Clayton via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG879a47a55ffb: Add the ability to debug through an exec into ld (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125253/new/ https://rev

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

2022-05-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125253/new/ https://reviews.llvm.org/D125253

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

2022-05-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:312 BreakpointSP dyld_break; - if (m_rendezvous.IsValid()) { + if (m_rendezvous.IsValid() && m_rendezvous.GetBreakAddress() != 0) { break_addr = m_rendez

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

2022-05-09 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:312 BreakpointSP dyld_break; - if (m_rendezvous.IsValid()) { + if (m_rendezvous.IsValid() && m_rendezvous.GetBreakAddress() != 0) { break_addr = m_rend

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

2022-05-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, wallace, yinghuitan, rdhindsa. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A previous commit enabled LLDB to be able to debug a prog