I think it's still worth printing something, even if it's just "Testing
LLDB with N processes", where you fill in the value for N
On Thu, Aug 27, 2015 at 4:07 PM Stephane Sezer wrote:
> sas added a comment.
>
> I removed the "Testing..." messages because $ won't be
> expanded in the context of a
sas added a comment.
I removed the "Testing..." messages because $ won't be
expanded in the context of a log message. Basically, you'll end up with
ninja/msvc/make printing "Testing LLDB with args:
--arch=x86_64;--executable;$;-s;/..." (even though it will be
running the right command with the
I'm not familiar with that $ expression, but if you're certain
that it's equivalent to what was there previously, this looks fine.
But why were the two "Testing LLDB..." messages removed?
On Thu, Aug 27, 2015 at 3:55 PM Stephane Sezer wrote:
> sas created this revision.
> sas added reviewers: z
sas created this revision.
sas added reviewers: zturner, clayborg.
sas added a subscriber: lldb-commits.
Instead of hardcoding the path, we should use $ which
works better when the output path differs, e.g. when building with MSVC.
$ is expanded during the generation of the final build
files, so
