[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35e60f5de180: [NFC][trace] simplify the instruction dumper (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

wallace updated this revision to Diff 425109. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124064/new/ https://reviews.llvm.org/D124064 Files: lldb/include/lldb/Target/TraceInstructionDumper.h lldb/so

[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:26 + lldb::InstructionSP instruction; + lldb_private::ExecutionContext exe_ctx; +}; jj10306 wrote: > It shouldn't be an issue now because this struct is never stored an

[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. two very minor comments, but looks good - I'm sure you already have, but be sure to run the dumper unittest test to ensure the output didn't change unexpectedly as a result some minor format

[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TraceInstructionDumper::DumpInstructions was becoming too big, so I'm refactoring it into