[Lldb-commits] [PATCH] D123984: [trace][intel pt] Add a memory usage test

2022-04-19 Thread walter erquinigo via Phabricator via lldb-commits
wallace abandoned this revision. wallace added a comment. I think I can do better than this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123984/new/ https://reviews.llvm.org/D123984 ___ lldb-commits mai

[Lldb-commits] [PATCH] D123984: [trace][intel pt] Add a memory usage test

2022-04-19 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. > To catch changes that may increase the memory by a lot? exactly. We might introduce changes in the decoder that might produce erroneous data and increase the memory usage or number of instructions by too much. For example, all our current tests work with small number

[Lldb-commits] [PATCH] D123984: [trace][intel pt] Add a memory usage test

2022-04-19 Thread Jakob Johnson via Phabricator via lldb-commits
jj10306 added a comment. What is the intention of this test? To catch changes that may increase the memory by a lot? I'm concerned this could be very flaky given that it's dependent on external factors (compiler output, context switches, etc). Now that we have this test, is there any value in ha

[Lldb-commits] [PATCH] D123984: [trace][intel pt] Add a memory usage test

2022-04-18 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The existing tests that check for the memory usage of the decoded trace are using small binaries, and in this case the memo