[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

2022-04-12 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Sounds good. I think it's test-and-use for lldb, and debugserver ended up structure the same way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123616/new/ https://reviews.llvm.org/D123616 ___ lldb-commits maili

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

2022-04-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. That also works for me, but then let's remove the corresponding logic in CMake as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123616/new/ https://reviews.llvm.org/D123616 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

2022-04-12 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. fwiw, commit 681f6c2f552fb9b57380f4bfd453e1fc9b6a099e Author: Jason Molenda Date: Tue Dec 18 22:21:48 2018 + Un-conditionalize use of libcompression. debugserver only builds on Darwin systems and libcompression has been in the OS for over

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

2022-04-12 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I think we only support building debugserver on macOS systems that have libcompression. Was there a configuration where this resulted in an error? lldb needs to test for libcompr

[Lldb-commits] [PATCH] D123616: [debugserver] Add HAVE_LIBCOMPRESSION guards

2022-04-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. The current debugserver CMake allows it to be built with or without libcompression. It conditionally links against libcompression if it's a