This revision was automatically updated to reflect the committed changes.
Closed by commit rL246842: RenderScript pending kernel breakpoints. (authored
by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D12360?vs=33425&id=34018#toc
Repository:
rL LLVM
http://reviews.llvm.org
jingham added a comment.
That looks great. Here are some comments that are not requirements for getting
this in but just for you to consider:
If you think you are ever likely to add different ways to specify the name
(e.g. if passing a regex might be useful) it might be good to pass the name a
EwanCrawford added a comment.
Does this address your concerns Jim?
Repository:
rL LLVM
http://reviews.llvm.org/D12360
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
EwanCrawford updated this revision to Diff 33425.
EwanCrawford added a comment.
Thanks for taking a look.
Previously we just tried to find a way to leverage the existing
BreakpointResovlerName, and SearchFilter.
However your suggestion to create a new BreakpointResolver works a lot better,
and
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
So there are two issues I see here.
The first is that you seem to have invented a parallel mechanism to the
breakpoint resolver mechanism to handle re-resolving breakpoints on shar
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good for now, but we should add a way so that plug-ins can extend the
"breakpoint set", "breakpoint delete", and other breakpoint commands so we
don't have a bunch of fragmented extr
EwanCrawford created this revision.
EwanCrawford added reviewers: clayborg, jingham.
EwanCrawford added subscribers: lldb-commits, domipheus, ADodds.
EwanCrawford set the repository for this revision to rL LLVM.
Currently the RS breakpoint command can only find a kernel if it's in an
already load
