aprantl added a comment.
This turned out to be unnecessary, because Process already exposes this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122347/new/
https://reviews.llvm.org/D122347
___
lldb-commi
kastiglione added inline comments.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:216
+llvm::Optional ProcessGDBRemote::GetAddressingBits() {
+ return m_gdb_comm.GetAddressingBits();
+}
Thought: should this API return a mask instead?
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7504dd5e00f5: Expose GetAddressingBits() in the Process API.
(authored by aprantl).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122347/new/
https://reviews.llvm.org/D122347
___
lldb-commits mailing list
aprantl created this revision.
aprantl added reviewers: JDevlieghere, jasonmolenda.
Herald added a project: All.
aprantl requested review of this revision.
See https://github.com/apple/llvm-project/pull/4110 for motivation and context.
https://reviews.llvm.org/D122347
Files:
lldb/include/lldb
