[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG05b4bf257124: [trace][intelpt] Introduce instruction Ids (authored by Walter Erquinigo ). Changed prior t

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 418680. wallace added a comment. - Bring back the --continue command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 Files: lldb/include/lldb/Target/TraceCursor.h

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:2201 +// command +if (cmd.find(" repeat") == std::string::npos) + cmd += " repeat"; This " repeat" is pretty hacky here. If we can't get away without adding any

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 418361. wallace marked 2 inline comments as done. wallace added a comment. Some updates: - Modified `thread trace dump instructions` to accept one single thread instead of many. The reason is that, with the new --id argument, traversing multiple threads doe

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:50 + /// Additional options for configuring the dumping. + TraceInstructionDumper(lldb::TraceCursorUP &&cursor_up, Stream &s, + const TraceInstructionDumperO

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 418032. wallace added a comment. fix some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

clayborg added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:162-166 + /// - In terms of efficiency, moving the cursor to a given id should be as + /// fast + /// as possible, but not necessarily O(1). That's why the recommended way to + /// travers

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 417828. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/Trace

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 417827. wallace added a comment. - improve documentation - use lldb::user_id_t - add the new TraceInstructionDumperOptions struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Target/TraceCursor.h:211-214 + /// A unique identifier for the instruction or error this cursor is + /// pointing to

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. nice work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 ___

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 417389. wallace marked 2 inline comments as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Couple minor things Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:66 private: + /// Indicate the dumper that no more data is available in the tr

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace created this revision. wallace added reviewers: jj10306, clayborg, zrthxn. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In order to support quick arbitrary access to instructions in the trace,