[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416532. zrthxn added a comment. Reflow to 80 cols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/docs/index.rst lldb/docs/use/intel_pt.rst Index: lld

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Please reflow the document to match the 80 column limit observed in the other docs. LGTM with that addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

wallace accepted this revision. wallace added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn added a comment. Here is the screenshot as well as the HTML file The screenshot doesn't have the CSS theming... F22478403: _home_alisamar_Desktop_lldb-build_tools_lldb_docs_html_use_intel_pt.html.png F22478406: intel_pt.html

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416506. zrthxn added a comment. Herald added a subscriber: arphaman. Referenced IPT doc from main page Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/do

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Pretty nice improvement! Now you need to reference this doc from the main page. See this reference patch https://reviews.llvm.org/D82064. According to it, you need to move this doc

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416287. zrthxn added a comment. Switched to RST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/docs/intel_pt.rst Index: lldb/docs/intel_pt.rst

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

wallace requested changes to this revision. wallace added a comment. Thank you very much for helping out with the documentaiton! As Jonas said, move the file to lldb/docs/intel_pt.rst and modify the necessary bits (some CMake changes) so that the documentation eventually appears in https://lldb

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn added a comment. In D121935#3389954 , @JDevlieghere wrote: > Can we include this in the `docs` folder instead? Having READMEs spread > throughout the sources isn't going to be particularly discoverable. Sure can. Should I also use RST instead of

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Can we include this in the `docs` folder instead? Having READMEs spread throughout the sources isn't going to be particularly discoverable. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn created this revision. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121935 Files: lldb/source/Plugins/Trace/intel-pt/README.md