[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere abandoned this revision. JDevlieghere added a comment. In D121161#3369641 , @labath wrote: > Amusingly enough, the problem is the custom operator| used for bitmask enums. > D121281 ought to fix that (by mak

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

labath added a comment. Amusingly enough, the problem is the custom operator| used for bitmask enums. D121281 ought to fix that (by making the function constexpr). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121161/new/ https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

shafik added a comment. In D121161#3368117 , @JDevlieghere wrote: > In D121161#3367806 , @labath wrote: > >> The class has a constexpr constructor. I thought that would be enough to >> avoid runtime initializati

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere added a comment. In D121161#3367806 , @labath wrote: > The class has a constexpr constructor. I thought that would be enough to > avoid runtime initialization. Is this being flagged by something? It is getting flagged by -Wglobal-constructo

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

labath added a comment. The class has a constexpr constructor. I thought that would be enough to avoid runtime initialization. Is this being flagged by something? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121161/new/ https://reviews.llvm.org/D121161 ___

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: All. JDevlieghere requested review of this revision. Avoid a static initializer for Log::Channel in LLDBLog.cpp https://reviews.llvm.org/D121161 Files: lldb/source/Utility/LLDBLog.cpp Index: l