[Lldb-commits] [PATCH] D120966: Remove cases of using namespace std

2022-03-04 Thread Shafik Yaghmour via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9bd72b5c2585: [LLDB] Remove cases of using namespace std (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D120966: Remove cases of using namespace std

2022-03-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120966/new/ https://reviews.llvm.org/D120966 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120966: Remove cases of using namespace std

2022-03-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. As a side note, I noticed that we don't prefix typedefs from `cstdint` with `std::` e.g. `size_t`. These typedefs are not guaranteed to be in the global namespace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120966/new/ https://reviews.llvm.org/D120966 _

[Lldb-commits] [PATCH] D120966: Remove cases of using namespace std

2022-03-03 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik created this revision. shafik added reviewers: labath, aprantl, JDevlieghere. Herald added a project: All. shafik requested review of this revision. We had `using namespace std;` sprinkled around several source files and tests. This also follows the LLVM coding standard