Re: [Lldb-commits] [PATCH] D12092: [ValueObjectSynthetic] Override GetDeclaration.

2015-08-17 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 32362. sivachandra added a comment. Override GetDeclaration in ValueObjectDynamicValue as well. http://reviews.llvm.org/D12092 Files: include/lldb/Core/ValueObjectDynamicValue.h include/lldb/Core/ValueObjectSyntheticFilter.h source/Core/ValueObjec

Re: [Lldb-commits] [PATCH] D12092: [ValueObjectSynthetic] Override GetDeclaration.

2015-08-17 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. That looks reasonable Does ValueObjectDynamic need the same change? You could have dynamic+synthetic combinations (e.g. NSArray/NSDictionary on Mac OS X) where the synthetic value sits on top of the dynamic value http://reviews.llvm.org/D12092 __

[Lldb-commits] [PATCH] D12092: [ValueObjectSynthetic] Override GetDeclaration.

2015-08-17 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added reviewers: clayborg, granata.enrico. sivachandra added a subscriber: lldb-commits. Returns the declaration of the non-sythetic value. http://reviews.llvm.org/D12092 Files: include/lldb/Core/ValueObjectSyntheticFilter.h source/Core/ValueObj