[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6ee17f22a7: [lldb] Warn when we fail to find dwo/dwp files (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere accepted this revision. JDevlieghere added a comment. Cool, thanks for the explanation. Ship it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews.llvm.org/D120892 __

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

labath added a comment. In D120892#3357780 , @JDevlieghere wrote: > Might a `llvm::once_flag` + `llvm::call_once` be simpler? Simpler... maybe.. depends how you look at it. But, synchronization-wise, it is overkill. once_flag ensures that none of the

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

labath added a comment. In D120892#3357424 , @JDevlieghere wrote: > FWIW I'm planning some changes to the error reporting "soonish". The gist is > using error/warning events which Xcode (or VSCode) can subscribe to. I'll > send out an RFC with more det

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere added a comment. Might a `llvm::once_flag` + `llvm::call_once` be simpler? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews.llvm.org/D120892 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

labath updated this revision to Diff 412774. labath added a comment. This code can be invoked concurrently (during indexing). Use atomic test-and-set to ensure correctness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews.l

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. FWIW I'm planning some changes to the error reporting "soonish". The gist is using error/warning events which Xcode (or VSCode) can subscribe to. I'll send out an RFC with m

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. This ensures that the user is aware that many commands will not work correctly. We print the warning only once (per module) to