[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf921006d379: [lldb] Remove the global platform list (authored by labath). Changed prior to commit: https://reviews.llvm.org/D120810?vs=420507&id=422489#toc Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

JDevlieghere added a comment. Still LGTM. Apologies for the new rebase conflict introduced by e90d8f024b2b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120810/new/ https://rev

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

labath updated this revision to Diff 420507. labath added a comment. Reopening, since the last attempt was quite some time ago, and the rebase was non-trivial. Functionally, there are no real changes. The one-liner in dotest.py is somewhat interesting, as it was necessary for (emu|simu)lator plat

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

labath added a comment. (I'm not going to land this immediately, since I've also learned that this breaks running the test suite against the qemu platform -- which works right now, but it seems that is mostly accidental. I will switch gears and make the qemu platform more test-suite compatible

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

labath added inline comments. Comment at: lldb/source/Plugins/Platform/gdb-server/CMakeLists.txt:10 lldbPluginProcessUtility +lldbPluginProcessGDBRemote ) thakis wrote: > It doesn't seem like lldb cares about this kind of thing, but this adds a > dep

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/gdb-server/CMakeLists.txt:10 lldbPluginProcessUtility +lldbPluginProcessGDBRemote ) It doesn't seem like lldb cares about this kind of thing, but this adds a dependency cycle: ll

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

This revision was automatically updated to reflect the committed changes. Closed by commit rGffb9429b6f3c: [lldb] Remove the global platform list (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120810/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

labath added inline comments. Comment at: lldb/source/Target/Platform.cpp:1891 + +PlatformSP PlatformList::GetOrCreate(const ArchSpec &arch, + ArchSpec *platform_arch_ptr, JDevlieghere wrote: > [Nit/pedantic] We have a few call

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. It's always great to see changes that enable more testing. I left one inline comment/nit but besides that this LGTM. Comment at: lldb/source/Target/Platform.cpp:

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. Herald added subscribers: mgorny, emaste. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. This patch moves the platform creation and selection logic into the