[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay added a comment. In D120718#3352450 , @JDevlieghere wrote: > I think the better solution here is to get rid of the `using namespace llvm;` > in the implementation file instead. Done. PTAL. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay updated this revision to Diff 412361. emrekultursay added a comment. Removed "using namespace llvm" from the implementation file and qualified all associated references with "llvm::". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12071

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

labath added a comment. In D120718#3352635 , @shafik wrote: > In D120718#3352450 , @JDevlieghere > wrote: > >> I think the better solution here is to get rid of the `using namespace >> llvm;` in the implementati

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

shafik added a comment. In D120718#3352450 , @JDevlieghere wrote: > I think the better solution here is to get rid of the `using namespace llvm;` > in the implementation file instead. That is a good point. I did a quick look at the file `DataFileCache.

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

JDevlieghere added a comment. Herald added a project: All. I think the better solution here is to get rid of the `using namespace llvm;` in the implementation file instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay added a comment. Hi shafik, can you also submit it? I don't have submit permission. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ ll

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay created this revision. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are two DataExtractors in scope: one from the llvm namespace and one from the lldb_private namespace. Some Microsoft Visual C++ compile