andcarminati added inline comments.
Comment at: lldb/source/Symbol/ObjectFile.cpp:559
+ lldb::offset_t section_offset) const {
+ offset_t offset = section->GetOffset() + section_offset;
+ return m_data.GetCStr(&offset);
Wouldn't it
labath added a comment.
I don't think this implementation is sound. If you look at the implementation
of `ReadSectionData` you'll see that there is a lot more involved in reading
data from a section than just incrementing a pointer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
augusto2112 added inline comments.
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:677
+ const char *GetCStrFromSection(Section *section,
+ lldb::offset_t section_offset) const;
+
aprantl wrote:
> Should we call it `GetCStringFr
aprantl added inline comments.
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:676
+ const char *GetCStrFromSection(Section *section,
+ lldb::offset_t section_offset) const;
Can you add a doxygen comment for the method?
augusto2112 created this revision.
augusto2112 added reviewers: aprantl, JDevlieghere.
augusto2112 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D120578
Files:
lldb/includ
