[Lldb-commits] [PATCH] D120322: [lldb] Simplify HostThreadMacOSX

2022-02-23 Thread Pavel Labath via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf4568e12219f: [lldb] Simplify HostThreadMacOSX (authored by labath). Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D120322: [lldb] Simplify HostThreadMacOSX

2022-02-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostThreadMacOSX.mm:17-20 + NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; + lldb::thread_result_t result = HostThreadPosix::ThreadCreateTrampoline(arg); + [pool drain]; + return resul

[Lldb-commits] [PATCH] D120322: [lldb] Simplify HostThreadMacOSX

2022-02-22 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, jingham. labath requested review of this revision. Herald added a project: LLDB. The class is using an incredibly elaborate setup to create and destroy an NSAutoreleasePool object. We can do it in a much simpler way by making thos