This revision was automatically updated to reflect the committed changes.
Closed by commit rL244737: Fetch SDK version from PlatformAndroid (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D11935?vs=31822&id=31921#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:292
@@ +291,3 @@
+ 1);
+if (error.Fail() || status != 0 || v
tberghammer updated this revision to Diff 31822.
tberghammer added a comment.
Address review comments
http://reviews.llvm.org/D11935
Files:
source/Plugins/Platform/Android/PlatformAndroid.cpp
source/Plugins/Platform/Android/PlatformAndroid.h
Index: source/Plugins/Platform/Android/PlatformA
ovyalov added a comment.
Please see my comments.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:284
@@ +283,3 @@
+std::string version_string;
+RunShellCommand("getprop ro.build.version.sdk",
+GetWorkingDirectory(),
Co
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Fetch SDK version from PlatformAndroid
The SDK version implies the features supported by a given android
device. This
