mgorny updated this revision to Diff 401585.
mgorny added a comment.
Put the common test code into a common init function, add tests for armv7,
arm64, i386, ppc64le.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117707/new/
https://reviews.llvm.org/D117707
Files:
lldb/bindings/inter
mgorny updated this revision to Diff 401582.
mgorny added a comment.
Cover all fields with tests and add a test input generator.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117707/new/
https://reviews.llvm.org/D117707
Files:
lldb/bindings/interface/SBPlatform.i
lldb/include/lldb/
mgorny updated this revision to Diff 401421.
mgorny added a comment.
Initial PoC unit test — the idea is to verify field offsets and sizes against
known values taken from real siginfo_t.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117707/new/
https://reviews.llvm.org/D117707
Files:
mgorny updated this revision to Diff 401378.
mgorny added a comment.
Herald added a subscriber: fedor.sergeev.
Use `CreateStructForIdentifier()` whenever possible. Describe the remaining
union members.
Open question: do we care for 100% correct SPARC support? Given that it has
different `_sigfa
mgorny added a comment.
Hmm, maybe for the sub-structs, it'd be better to use
`TypeSystemClang::CreateStructForIdentifier()`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117707/new/
https://reviews.llvm.org/D117707
___
lldb-commits mailing
mgorny updated this revision to Diff 401364.
mgorny added a comment.
Cover more union members.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117707/new/
https://reviews.llvm.org/D117707
Files:
lldb/bindings/interface/SBPlatform.i
lldb/include/lldb/API/SBPlatform.h
lldb/include/ll
mgorny added a comment.
My current test program is:
#!/usr/bin/env python
import lldb
raw_data =
b'\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00up\n\x00\xe8\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
mgorny created this revision.
mgorny added reviewers: labath, emaste, krytarowski.
mgorny requested review of this revision.
To get some early feedback.
https://reviews.llvm.org/D117707
Files:
lldb/bindings/interface/SBPlatform.i
lldb/include/lldb/API/SBPlatform.h
lldb/include/lldb/API/SB
