This revision was automatically updated to reflect the committed changes.
Closed by commit rGcb5ea132d2ee: [lldb] Add long help to `crashlog` (authored
by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117165/new/
https://reviews.llvm.o
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Nice!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117165/new/
https://reviews.llvm.org/D117165
___
lldb-commits mailing list
lldb-comm
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117165/new/
https://reviews.llvm.org/D117165
_
kastiglione added inline comments.
Comment at: lldb/examples/python/crashlog.py:1236-1240
+def __lldb_init_module(debugger, internal_dict):
+debugger.HandleCommand(
+'command script add -c lldb.macosx.crashlog.Symbolicate crashlog')
+debugger.HandleCommand(
kastiglione added a comment.
> Can you see if also adding a "get_short_help" gets rid of that dopey:
Good call, it worked.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117165/new/
https://reviews.llvm.org/D117165
kastiglione updated this revision to Diff 399701.
kastiglione added a comment.
Add get_short_help, and add missing changes that should have been part of
original diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117165/new/
https://reviews.llvm.
jingham added a comment.
If adding the short help doesn't fix this, I'm fine with this change as is. We
can go down the getting rid of that placeholder rabbit hole at some other time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117165/new/
http
jingham added a comment.
Oops, forgot to include the "why requesting changes..."
Can you see if also adding a "get_short_help" gets rid of that dopey:
For more information run 'help crashlog' Expects 'raw' input (see 'help
raw-input'.)
line? It's getting added as the placeholder text in Co
jingham requested changes to this revision.
jingham added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/examples/python/crashlog.py:1236-1240
+def __lldb_init_module(debugger, internal_dict):
+debugger.HandleCommand(
+'command script
kastiglione added inline comments.
Comment at: lldb/examples/python/crashlog.py:1236-1240
+def __lldb_init_module(debugger, internal_dict):
+debugger.HandleCommand(
+'command script add -c lldb.macosx.crashlog.Symbolicate crashlog')
+debugger.HandleCommand(
kastiglione updated this revision to Diff 399517.
kastiglione added a comment.
refer to the debugger parameter, not lldb.debugger
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117165/new/
https://reviews.llvm.org/D117165
Files:
lldb/examples/pyt
kastiglione added a comment.
Herald added a subscriber: JDevlieghere.
The output of `help crashlog` is:
(lldb) help crashlog
For more information run 'help crashlog' Expects 'raw' input (see 'help
raw-input'.)
Syntax: crashlog
Usage: crashlog [options] [FILE ...]
Symbolicate o
kastiglione created this revision.
kastiglione added a reviewer: jingham.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Convert the `crashlog` command to be implemented as a class. The `Symbolicate`
function is switched to a c
13 matches
Mail list logo
