[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

mgorny added a comment. In D117113#3251838 , @stella.stamenova wrote: > This does not build correctly with gcc 7.3.1 on CentOS: Could you please try adding some `std::move()`s to the relevant returns? I don't have an access to such an ancient compiler.

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

labath added a comment. sounds like something that could be fixed by a couple of std::moves Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117113/new/ https://reviews.llvm.org/D117113 ___ lldb-commits mai

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This does not build correctly with gcc 7.3.1 on CentOS: /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/mnt/resource/1/b/llvm

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e74e5e9e3b9: [lldb] [llgs] Implement qXfer:siginfo:read (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1987 +NativeProcessLinux::GetSiginfo() const { + siginfo_t siginfo; + Status error = GetSignalInfo

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1987 +NativeProcessLinux::GetSiginfo() const { + siginfo_t siginfo; + Status error = GetSignalInfo(GetCurrentThreadID(), &siginfo); labath wrote: > I'd be better

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

mgorny updated this revision to Diff 399478. mgorny marked 4 inline comments as done. mgorny added a comment. Implemented the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117113/new/ https://reviews.llvm.org/D117113 Files: lldb/include/lldb/Host/common/NativeProce

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

labath added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:195-198 + virtual llvm::Expected> + GetSiginfo() const { +return llvm::make_error(); + } I think it would be more natural/consistent to have this function on a

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Implement the qXfer:siginfo:read that is used to read the siginfo_t (extended signal information) for the current thread. This is cu