[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f6d3a376c9f: [LLDB] Fix setting of success in Socket::Close() (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Usually, the only thing one can do if a close fails is to log an error message, so it's not completely surprising that this has gone by unnoticed. It might be nice to insert a close call to on

[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

shafik added a comment. AFAICT this fix is correct but I am not sure how to verify of test it. I ran the test suite and it passed but that does not mean this is being covered. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116768/new/ https://reviews.llvm.org/D116768 __

[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

shafik created this revision. shafik added reviewers: labath, jingham, JDevlieghere. shafik requested review of this revision. Both `close` and `closesocket` should return `0` on success so using `!!` looks incorrect. I replaced this will a more readable `== 0` check. https://reviews.llvm.org/D