[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

jingham added a comment. In D115926#3199520 , @siger-young wrote: > In D115926#3199496 , @labath wrote: > >> I don't know if you've seen this but we have some description of it here >> https://lldb.llvm.org/desi

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young added a comment. In D115926#3199496 , @labath wrote: > I don't know if you've seen this but we have some description of it here > https://lldb.llvm.org/design/sbapi.html. The gist of it is: > > - be backward compatible > - don't depend on oth

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

labath added a comment. I don't know if you've seen this but we have some description of it here https://lldb.llvm.org/design/sbapi.html. The gist of it is: - be backward compatible - don't depend on other stuff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I actually quite like this, but we should figure out a way to do it while respecting our SB contracts. See inline comments for details. Comment at: lldb/bindings/l

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young updated this revision to Diff 395076. siger-young added a comment. Remove "return" to prevent memory leakage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115926/new/ https://reviews.llvm.org/D115926 Files: lldb/bindings/interface/S

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young created this revision. siger-young added reviewers: JDevlieghere, tammela. siger-young requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit supports registerubg breakpoint callback when using liblldb in Lua. (able to `Set