[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

2021-12-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. It would be better if Jason reviewed this, but my first thoughts after seeing this are: If we're going to be using both the PC and the CFA for frame comparison, do we really need to also skip a frame when doing the comparing? It seems like it should be sufficient to com

[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

2021-12-02 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Looking at `GetOneMoreFrame` I agree the logic matches up but don't understand the logic enough overall to approve. I'll leave that to others. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:697 + // theory we can have arbitrary number

[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

2021-12-01 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: JDevlieghere. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. A compiler can produce F