This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rG82de8df26f15: [lldb] Clarify StructuredDataImpl ownership
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D114791?vs=390672&id=393996#toc
labath marked an inline comment as done.
labath added inline comments.
Comment at: lldb/bindings/lua/lua-wrapper.swig:31
lldb::BreakpointLocationSP bp_loc_sp,
StructuredDataImpl *extra_args_impl
)
mib wrote:
> May be we should keep consistency with the `
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM with some minor nits.
Comment at: lldb/bindings/lua/lua-wrapper.swig:31
lldb::BreakpointLocationSP bp_loc_sp,
StructuredDataImpl *extra_args_impl
)
M
labath added inline comments.
Comment at: lldb/source/API/SBThreadPlan.cpp:72-73
if (thread)
-m_opaque_wp =
-std::make_shared(*thread, class_name, nullptr);
+m_opaque_wp = std::make_shared(*thread, class_name,
+
labath created this revision.
labath added reviewers: JDevlieghere, mib, jingham.
Herald added a subscriber: yaxunl.
labath requested review of this revision.
Herald added a project: LLDB.
StructuredDataImpl ownership semantics is unclear at best. Various
structures were holding a non-owning point
