nitesh.jain added a comment.
In https://reviews.llvm.org/D11465#826132, @tberghammer wrote:
> Thanks for all of the data. Based on this I think you are using a preview
> version of android O what reports SDK 25 but the linker works the way an SDK
> 26 system linker would do.
>
> I think the pro
tberghammer added a comment.
Thanks for all of the data. Based on this I think you are using a preview
version of android O what reports SDK 25 but the linker works the way an SDK 26
system linker would do.
I think the proper fix for the problem is to do something like what Greg
suggested to d
nitesh.jain added a comment.
The android version am using for testing is "O".
generic_mips64:/ # getprop ro.build.version.release
O
Repository:
rL LLVM
https://reviews.llvm.org/D11465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
nitesh.jain added a comment.
Hi Tamas,
> Run "target modules list"
(lldb) target modules list
[ 0] E6A47987----
/export/tmp/nin/LLVM/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/multiset/a.out
clayborg added a comment.
It would be nice to auto detect the names correctly?
Comment at: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp:389
+ struct __lldb_dlopen_result { void *image_ptr; const char
*error_str; } the_result;
+
labath added inline comments.
Comment at: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp:389
+ struct __lldb_dlopen_result { void *image_ptr; const char
*error_str; } the_result;
+ the_result.image_ptr = __dl_dlopen ("%s", 2);
tberghammer added a comment.
Hi Nitesh,
The way dlopen, dlclose and dl_phdr_iterate is implemented on android is pretty
strange until (and including) SDK 25. The trick is that these functions are
implemented inside "/system/bin/linker" with actual function names prefixed
with "__dl_". The link
nitesh.jain added inline comments.
Comment at: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp:389
+ struct __lldb_dlopen_result { void *image_ptr; const char
*error_str; } the_result;
+ the_result.image_ptr = __dl_dlopen ("%s",
tberghammer added a comment.
In http://reviews.llvm.org/D11465#300606, @labath wrote:
> In http://reviews.llvm.org/D11465#300581, @jingham wrote:
>
> > It seems like an awful lot of logic is duplicated between the POSIX &
> > Android versions of LoadImage when all that really changes is the name
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D11465#300581, @jingham wrote:
> It seems like an awful lot of logic is duplicated between the POSIX & Android
> versions of LoadImage when all that really changes is the name of the
> function you are calling
jingham added a subscriber: jingham.
jingham added a comment.
It seems like an awful lot of logic is duplicated between the POSIX & Android
versions of LoadImage when all that really changes is the name of the function
you are calling. Is it possible to centralize this some more?
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254504: Fix "process load/unload" on android (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D11465?vs=41491&id=41608#toc
Repository:
rL LLVM
http://reviews.llvm.org/D114
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D11465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tberghammer added inline comments.
Comment at: test/functionalities/load_unload/TestLoadUnload.py:201-204
@@ -205,7 +200,6 @@
-if lldb.remote_platform:
-dylibName = os.path.join(shlib_dir, 'libloadunload_a.so')
-elif self.platformIsDarwin():
+
tberghammer updated this revision to Diff 41491.
http://reviews.llvm.org/D11465
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py
source/API/SBProcess.cpp
source/Commands/CommandObjectProcess.
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41490.
tberghammer added a comment.
Herald added a subscriber: emaste.
Address review comments
http://reviews.llvm.org/D11465
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
pa
16 matches
Mail list logo
