[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. mlir-windows buildbot looks to be green now - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG058c5dfc78cd: Raise the minimum Visual Studio version to VS2019 (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D114639?v

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @stella.stamenova It looks like the mlir-windows buildbot is still using VS2017: CMake Error at cmake/modules/CheckCompilerVersion.cmake:39 (message): Host Visual Studio version must be at least 19.20, your version is 19.16.27045.0. Are you able to make the fix

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64 You accidentally added `-T host=x64` twice now

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 404076. RKSimon added a comment. fix cut+paste typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Users

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019 Win64" -Thost=x64 This line should change a bit more. For VS2019, it also nee

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403924. RKSimon added a comment. update lldb cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403574. RKSimon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb docs as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. Herald added a subscriber: JDevlieghere. In D114639#3273831 , @RKSimon wrote: > In D114639#3273761 , > @stella.stamenova wrote: > >> Can we update the lldb instructions as part of t