This revision was automatically updated to reflect the committed changes.
Closed by commit rG165545c7a431: [lldb/gdb-remote] Ignore spurious ACK packets
(authored by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114520/new/
https://reviews.
labath added inline comments.
Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationTest.cpp:56
{{"$foobar#79"}, {"foobar"}},
- {{"$}}#fa"}, {"]"}},
- {{"$x*%#c7"}, {"x"}},
mgorny wrote:
> I don't get how this is relevant to
mgorny accepted this revision.
mgorny added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationTest.cpp:56
{{"$foobar#79"}, {"foobar"}},
- {{"$}}#fa"}, {"]"}},
- {{"$x*%#c7"}, {"xx
labath created this revision.
labath added reviewers: mgorny, jasonmolenda.
labath requested review of this revision.
Herald added a project: LLDB.
Although I cannot find any mention of this in the specification, both
gdb and lldb agree on sending an initial + packet after establishing the
connect
