This revision was automatically updated to reflect the committed changes.
Closed by commit rG7f09ab08de5a: [lldb] Fix [some] leaks in python bindings
(authored by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114259/new/
https://reviews.llv
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Nice cleanup. LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114259/new/
https://reviews.llvm.org/D114259
labath added inline comments.
Comment at: lldb/bindings/python/python-swigsafecast.swig:61-67
+PythonObject ToSWIGWrapper(std::unique_ptr value_sb) {
+ return ToSWIGHelper(value_sb.release(), SWIGTYPE_p_lldb__SBValue);
+}
+
+PythonObject ToSWIGWrapper(lldb::ValueObjectSP value_s
labath created this revision.
labath added reviewers: JDevlieghere, jingham.
labath requested review of this revision.
Herald added a project: LLDB.
Using an lldb_private object in the bindings involves three steps
- wrapping the object in it's lldb::SB variant
- using swig to convert/wrap that t
