clayborg added a comment.
I resubmitted with a fix in https://reviews.llvm.org/D114288
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113965/new/
https://reviews.llvm.org/D113965
___
lldb-commits mailing
clayborg added a comment.
I had to revert this. There is a deadlock in:
void Module::PreloadSymbols() {
std::lock_guard guard(m_mutex);
SymbolFile *sym_file = GetSymbolFile();
if (!sym_file)
return;
// Prime the symbol file first, since it adds symbols to the symbol tab
This revision was automatically updated to reflect the committed changes.
Closed by commit rG951b107eedab: [NFC] Refactor symbol table parsing. (authored
by clayborg).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113965/new/
https://reviews.llvm.or
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113965/new/
https://reviews.llvm.org/D113965
___
lldb-commits mailing list
lldb-commi
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This is a good cleanup independently of the caching feature.
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:344
+ /// The symbol table to populate.
+ virtual void Pa
clayborg created this revision.
clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace.
Herald added subscribers: sbc100, emaste.
clayborg requested review of this revision.
Herald added subscribers: lldb-commits, MaskRay, aheejin.
Herald added a project: LLDB.
Symbol table parsin
