This revision was automatically updated to reflect the committed changes.
Closed by commit rG098c01c132c8: [lldb] Refactor Platform::ResolveExecutable
(authored by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113487/new/
https://reviews.ll
labath added a comment.
Thanks, Greg.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113487/new/
https://reviews.llvm.org/D113487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
clayborg added a comment.
LGTM. I will ok soon if no one else chimes in!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113487/new/
https://reviews.llvm.org/D113487
___
lldb-commits mailing list
lldb-comm
labath added inline comments.
Comment at: lldb/source/Target/Platform.cpp:865
+
+Status
+Platform::ResolveRemoteExecutable(const ModuleSpec &module_spec,
Next step is to merge this with the `if (!m_remote_platform_sp)` path in
RemoteAwarePlatform::ResolveExecuta
labath created this revision.
labath added reviewers: JDevlieghere, jingham, clayborg, PatriosTheGreat.
labath requested review of this revision.
Herald added a project: LLDB.
Module resolution is probably the most complex piece of lldb [citation
needed], with numerous levels of abstraction, each