[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 marked 7 inline comments as done. xujuntwt95329 added a comment. I have submitted a new patch here: https://reviews.llvm.org/D113011 Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. In D112439#3102752 , @xujuntwt95329 wrote: > Thanks a lot for your comments, they are very useful and I learned a lot > about C++ by talking with you. > > I'll address these comments and submit a patch and request your review.

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. Thanks a lot for your comments, they are very useful and I learned a lot about C++ by talking with you. I'll address these comments and submit a patch and request your review. Much appreciated！ Comment at: lldb/unittests/Target/FindFileTest.cpp

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. Fixed in 58dd658583eec9af24ca1262e1bce9f884d65487 (Also left some nits in the test because I anyway looked over the code.) Comment at: lldb/unittests/Target/FindFileTest.cpp:27 +

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3102600 , @teemperor wrote: > In D112439#3102559 , @xujuntwt95329 > wrote: > >> In D112439#3102548 , @teemperor >> wrote: >> >>

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. In D112439#3102559 , @xujuntwt95329 wrote: > In D112439#3102548 , @teemperor > wrote: > >> In D112439#3102533 , >> @xujuntwt95329 wrote: >> >

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3102548 , @teemperor wrote: > In D112439#3102533 , @xujuntwt95329 > wrote: > >> In D112439#3102506 , @teemperor >> wrote: >> >>

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. In D112439#3102533 , @xujuntwt95329 wrote: > In D112439#3102506 , @teemperor > wrote: > >> In D112439#3098307 , >> @xujuntwt95329 wrote: >> >

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3102506 , @teemperor wrote: > In D112439#3098307 , @xujuntwt95329 > wrote: > >> Seems that patch can't build by CI because it is based on this patch. In my >> understand

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

teemperor added a comment. In D112439#3098307 , @xujuntwt95329 wrote: > Seems that patch can't build by CI because it is based on this patch. In my > understanding we need to merge this patch firstly and rebase that NFC patch > to let CI work, right?

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe19ae352ce2: normalize file path when searching the source map (authored by xujuntwt95329, committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

aprantl accepted this revision. aprantl added a comment. In D112439#3098307 , @xujuntwt95329 wrote: > Hi, @aprantl > > I've submitted a NFC patch here: > https://reviews.llvm.org/D112863 > > Seems that patch can't build by CI because it is based on this

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 marked 2 inline comments as done. xujuntwt95329 added a comment. Hi, @aprantl I've submitted a NFC patch here: https://reviews.llvm.org/D112863 Seems that patch can't build by CI because it is based on this patch. In my understanding we need to merge this patch firstly and rebase

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 383553. xujuntwt95329 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp lldb/unittests/T

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

aprantl added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:33 // nomalized path pairs to ensure things match up. ConstString NormalizePath(ConstString path) { // If we use "path" to construct a FileSpec, it will normalize the path for ---

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 383083. xujuntwt95329 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp lldb/unittests/T

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:33-37 ConstString NormalizePath(ConstString path) { // If we use "path" to construct a FileSpec, it will normalize the path for // us. We then grab the string and turn it back int

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

JDevlieghere added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:33-37 ConstString NormalizePath(ConstString path) { // If we use "path" to construct a FileSpec, it will normalize the path for // us. We then grab the string and turn it back into

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. I've added the unit test. The "FindFile" method requires the FileSystem, so I added a new file rather then put these code into exist PathMappingListTest.cpp Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1124

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 382237. xujuntwt95329 added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp lldb/unittest

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 382235. xujuntwt95329 added a comment. Herald added a subscriber: mgorny. add unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Targ

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3084948 , @wallace wrote: > Is it possible to add a test for that? In any case, this makes sense to me In D112439#3085304 , @clayborg wrote: > Adding a test would be g

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

clayborg added a comment. Adding a test would be great for this. Please add one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Is it possible to add a test for that? In any case, this makes sense to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://r

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 created this revision. xujuntwt95329 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The key stored in the source map is a normalized path string with host's path style, so it is also necessary to normalize the file path durin