danilashtefan updated this revision to Diff 382325.
danilashtefan added a comment.
Minor corrections
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112180/new/
https://reviews.llvm.org/D112180
Files:
lldb/source/Plugins/Language/CPlusPlus/CPlusPl
wallace added inline comments.
Comment at:
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/bitset/TestDataFormatterGenericBitset.py:32-35
for i in range(size):
child = var.GetChildAtIndex(i)
self.assertEqual(child.GetVal
wallace requested changes to this revision.
wallace added a comment.
This revision now requires changes to proceed.
almost there!
Comment at: lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp:20
-class BitsetFrontEnd : public SyntheticChildrenFrontEnd {
+// This class
danilashtefan updated this revision to Diff 382066.
danilashtefan added a comment.
I have corrected everything according to the previous comments. Wallace will
kindly help me to format the code, since I have the following formatter error
Stack dump:
0.Program arguments: clang-format -lines=1
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Thanks! This is looking pretty good, I just have some final minor comments
about some code that I think we can also drop/split-out.
Comment at: lldb/source/P
wallace updated this revision to Diff 381655.
wallace added a comment.
nit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112180/new/
https://reviews.llvm.org/D112180
Files:
lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt
lldb/source/Plug
wallace updated this revision to Diff 381653.
wallace added a comment.
addressed all comments.
I was able to dedup all the implementation files and the tests, and indeed
passing
the make flags to the build method was a good trick.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Thanks for working on this!
Some notes/nits:
- nit: The patch seems to have a bunch of unrelated clang-format changes for
CPlusPlusLanguage.cpp in it. You can prevent that by
danilashtefan created this revision.
Herald added a subscriber: mgorny.
danilashtefan requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D112180
Files:
lldb/source/Plugins/Lang
