[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

lhames added a comment. Yeah -- this seems like a good idea to me. Thanks Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

MaskRay accepted this revision. MaskRay added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.org/D111454 __

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

dexonsmith added a comment. Seems like a reasonable move to me. Comment at: llvm/include/llvm/MC/TargetRegistry.h:18-19 #ifndef LLVM_SUPPORT_TARGETREGISTRY_H #define LLVM_SUPPORT_TARGETREGISTRY_H Should be `LLVM_MC_TARGETREGISTRY_H` now. ===

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

rnk added a comment. Thanks for the review! I uploaded it a bit quickly because I wanted to kick off Bazel presubmit testing, since I haven't replicated that locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.o