This revision was automatically updated to reflect the committed changes.
Closed by commit rG4651576edd09: Recognize the Swift compiler in DW_AT_producer
(authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D111278?vs=377977&id=378001#toc
Repos
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684
+ llvm::SmallVector matches;
+ if (g_swiftlang_version_regex.Execute(producer, &matches)
aprantl updated this revision to Diff 377977.
aprantl added a comment.
Const.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111278/new/
https://reviews.llvm.org/D111278
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
lldb
aprantl added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684
+ llvm::SmallVector matches;
+ if (g_swiftlang_version_regex.Execute(producer, &matches)) {
+ m_producer_version.tryParse(matches[1]);
aprantl wrote:
> JDevli
aprantl added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684
+ llvm::SmallVector matches;
+ if (g_swiftlang_version_regex.Execute(producer, &matches)) {
+ m_producer_version.tryParse(matches[1]);
JDevlieghere wrote:
> F
shafik added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:674
+ static RegularExpression g_swiftlang_version_regex(
+ llvm::StringRef(R"(swiftlang-([0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?))"));
`const`?
CHANGES SINCE LAST AC
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684
+ llvm::SmallVector matches;
+ if (g_swiftlang_version_regex.Execute(producer, &matches)) {
+ m_producer_version.tryParse(matches[1]);
For consistency wi
aprantl updated this revision to Diff 377702.
aprantl added a comment.
Sort variables in a more logical order.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111278/new/
https://reviews.llvm.org/D111278
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
lldb/source/Plugins/Sy
aprantl created this revision.
aprantl added reviewers: JDevlieghere, kastiglione, jingham.
aprantl requested review of this revision.
This patch adds support for Swift compiler producer strings to DWARFUnit.
https://reviews.llvm.org/D111278
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFUn
