[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

2021-10-05 Thread Keith Smiley via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0f3254b29f37: [lldb] Improve help for platform put-file (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110981/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

2021-10-05 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110981/new/ https://reviews.llvm.org/D110981

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

2021-10-04 Thread Keith Smiley via Phabricator via lldb-commits
keith updated this revision to Diff 377010. keith marked an inline comment as done. keith added a comment. Update text about resolving paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110981/new/ https://reviews.llvm.org/D110981 Files: lldb/s

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

2021-10-04 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:1079 + +Omitting the destination places the file in the debuggers current working directory.)"); } It would be more correct to say "the platform working directory" (a

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

2021-10-01 Thread Keith Smiley via Phabricator via lldb-commits
keith created this revision. keith added a reviewer: kastiglione. keith requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Herald added a subscriber: JDevlieghere. Previously it was not clear what arguments this required, or what it would do