[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

aprantl added a comment. In D110893#3035753 , @labath wrote: > Some general thoughts: > > - instead of throwing patches around in might be good to have a discussion > thread to determine all the requirements and figure out the general direction Got to a

[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

labath added a comment. Some general thoughts: - instead of throwing patches around in might be good to have a discussion thread to determine all the requirements and figure out the general direction - it would be better to have a series of smaller patches (like this one) instead one big patch

[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

clayborg added a comment. I will have the new version that implements many of these changes submitted by tonight CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110893/new/ https://reviews.llvm.org/D110893 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. please don't commit this. I am in the process of doing very similar stuff in https://reviews.llvm.org/D110804 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110893/new/

[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Mechanically, this sgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110893/new/ https://reviews.llvm.org/D110893 ___ lldb-commits mai

[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

JDevlieghere updated this revision to Diff 376398. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110893/new/ https://reviews.llvm.org/D110893 Files: lldb/include/lldb/Target/Target.h lldb/include/lldb/Utility/Analytics.h lldb/include/lldb/Utility/Metrics.def lldb/include/lldb/lld

[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, jingham, labath. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Refactor LLDB's current statistics into a single class named Analytics which consists of different metrics. https://rev