[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a6ba3675177: [lldb] Convert misc. StringConvert uses (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D110447?vs=375024&id=375030#toc Repository:

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

mgorny added inline comments. Comment at: lldb/source/Symbol/SymbolContext.cpp:986 -m_end_line = StringConvert::ToSInt32(spec_string, 0, 0, &return_value); -if (return_value) m_type |= eLineEndSpecified; teemperor wrote: > This change and the one a

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

mgorny added a comment. In D110447#3022340 , @teemperor wrote: > If you have the time, it would be nice to drop FIXME's above the few places > where the return value of `to_integer` is not checked. Those always make > great beginner bugs. Beginner? I'm

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This patch makes me very happy. I have one comment regarding one small change in behaviour, but otherwise this LGTM. If you have the time, it would be nice to drop FIXME's above the few

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

mgorny updated this revision to Diff 375024. mgorny added a comment. Reverting debugserver part, this *beep* doesn't use LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110447/new/ https://reviews.llvm.org/D110447 Files: lldb/source/Interpreter/OptionValueArray.cpp lldb/source/

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere. mgorny requested review of this revision. Replace misc. StringConvert uses with llvm::to_integer() and llvm::to_float(), except for cases where further refactoring is planned. The purpose of this chan