This revision was automatically updated to reflect the committed changes.
Closed by commit rG93b82f45bc3e: [lldb] [Host] Refactor XML converting getters
(authored by mgorny).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D110410?vs=374829&id=375212#toc
Reposit
mgorny added inline comments.
Comment at: lldb/source/Host/common/XML.cpp:299-304
+ std::string text;
+ if (GetElementText(text) && llvm::to_integer(text,value, base))
+return true;
+
+ value = fail_value;
+ return false;
labath wrote:
> /me wonders if it
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Host/common/XML.cpp:299-304
+ std::string text;
+ if (GetElementText(text) && llvm::to_integer(text,value, base))
+return true;
+
+ value =
mgorny updated this revision to Diff 374829.
mgorny added a comment.
Remove obsolete includes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110410/new/
https://reviews.llvm.org/D110410
Files:
lldb/source/Host/common/XML.cpp
lldb/unittests/Host/CMakeLists.txt
lldb/unittests/Host/
mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere.
mgorny requested review of this revision.
Refactor the XML converting attribute and text getters to use LLVM API.
While at it, remove some redundant error and missing XML support
handling, as the calle
