[Lldb-commits] [PATCH] D109384: [lldb] Delete IRExecutionUnit::SearchSpec

2021-09-08 Thread Alex Langford via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG303b27f21b98: [lldb] Delete IRExecutionUnit::SearchSpec (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109384: [lldb] Delete IRExecutionUnit::SearchSpec

2021-09-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109384/new/ https://reviews.llvm.org/D109384 ___

[Lldb-commits] [PATCH] D109384: [lldb] Delete IRExecutionUnit::SearchSpec

2021-09-07 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Looks fine to me. I will let others that specialize more in the expression evaluator accept this., though it would be good to verify this code looks the same in the Swift branches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D109384: [lldb] Delete IRExecutionUnit::SearchSpec

2021-09-07 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, teemperor, JDevlieghere. bulbazord requested review of this revision. Herald added a project: LLDB. IRExecutionUnit::SearchSpec is a struct that encapsulates information needed to look for a symbol. Specifically, it is