[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

This revision was automatically updated to reflect the committed changes. Closed by commit rG6de63b3ba5e2: [lldb/lua] Force Lua version to be 5.3 (authored by Siger Yang ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/ne

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

siger-young updated this revision to Diff 375086. siger-young added a comment. Remove "REQUIRED" flags when finding Lua at "FindLuaAndSwig.cmake". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/new/ https://reviews.llvm.org/D108515 Files:

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

tammela added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) mstorsjo wrote: > siger-young wrote: > > mstorsjo wrote

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

siger-young added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) mstorsjo wrote: > This breaks building in setups wh

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

mstorsjo added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) mstorsjo wrote: > This breaks building in setups where

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

mstorsjo added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) This breaks building in setups where SWIG is available

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bb42dc6b114: [lldb/lua] Force Lua version to be 5.3 (authored by Siger Yang ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/ne

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/new/ https://reviews.llvm.org/D108515 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

tammela accepted this revision. tammela added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/new/ https://reviews.llvm.org/D108515 _

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

siger-young created this revision. siger-young added reviewers: tammela, JDevlieghere. Herald added a subscriber: mgorny. siger-young requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Due to CMake cache, find_package in FindLuaAndSwig.cmake w