[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107767/new/ https://reviews.llvm.org/D107767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG875a16bcfc28: [lldb] Fix break introduced in 14735ca (authored by rgiese, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I'm landing this to unbreak Green Dragon. @mgorny Just a heads up, I think this also broke one test with debugserver: ==

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Robin Giese via Phabricator via lldb-commits
rgiese updated this revision to Diff 365190. rgiese added a comment. Trying this patch-of-a-patch thing again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107767/new/ https://reviews.llvm.org/D107767 Files: lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulat

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Robin Giese via Phabricator via lldb-commits
rgiese updated this revision to Diff 365186. rgiese added a comment. Incorporating feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107767/new/ https://reviews.llvm.org/D107767 Files: lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm Ind

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. My bad, I missed that the patch isn't just renaming but actually adding a new option. Let me run the tests with the proposed change (feel free to update the review in the meant

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Robin Giese via Phabricator via lldb-commits
rgiese added a comment. @teemperor please hold while I figure out how to update the patch with @mgorny 's cleaner suggestion. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107767/new/ https://reviews.llvm.org/D107767 _

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. I'm sorry about missing this. Comment at: lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm:428-431 if ((oflag & O_RDWR) || (oflag & O_RDONLY)) -file_options |= File::eOpenOptionRead; +

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. I assume you don't have commit access so I'll land this for you in a minute :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Robin Giese via Phabricator via lldb-commits
rgiese created this revision. rgiese requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `File::OpenOptions` were renamed; this fixes up a callsite that breaks for macOS builds. Repository: rG LLVM Github Monorepo https://reviews.llvm