[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb26e1efc424a: [LLDB][GUI] Add Breakpoints window (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @clayborg This is unrelated to D107761 , so it should be safe to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llvm.org/D107386 __

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev updated this revision to Diff 365216. OmarEmaraDev added a comment. - Fix possible crash in SetText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llvm.org/D107386 Files: lldb/source/Core/IOHandlerCursesGU

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just fix the possible crash when SetText gets a NULL string pointer, and this is good to go. We also need to get the "is_pad(...)" fix in before this can be submitted right? =

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @jingham I see. Thanks! Here is how it looks now: F18450643: 20210809-130123.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llvm.org/D107386 __

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev updated this revision to Diff 365145. OmarEmaraDev added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. - Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llv

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

clayborg added a comment. I like the new UI! I think you are right in that we don't need the address on the breakpoint location line if we can expand it and see it in the location children, so lets remove it from there. Other than that it looks good. The only other suggestion I would have is if

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

jingham added a comment. In D107386#2932037 , @OmarEmaraDev wrote: > @clayborg With you suggestions it currently looks like this. The concern I > have is that lines are now 36 characters longer, and some important > information are now truncated. The b

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @clayborg With you suggestions it currently looks like this. The concern I have is that lines are now 36 characters longer, and some important information are now truncated. The breakpoint and breakpoint locations IDs seems to be just the index of the objects in th

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

clayborg added a comment. In D107386#2928910 , @OmarEmaraDev wrote: > By the way, it would be nice to have D107182 > commited because it is needed by the > search form. Just committed it! Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:4331-4333 +if (StateIsRunningState(process->GetState())) { + return false; +} Remove {} for single statement if statements per LLVM guidelines Comm

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @clayborg What do you think? Should we add another tree level with more details or do something else? By the way, it would be nice to have D107182 commited because it is needed by the search form. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. I faced a bit of difficulty in this patch, so it is not exactly complete. One issue is that breakpoint descriptions can be very long, I tried to implemented multiline items to workaround this, but that didn't work out and was

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a breakpoints window that lists all breakpoints an