This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG04195843ef91: [intel pt] Add TSC timestamps (authored by
Walter Erquinigo ).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106328/new/
https://reviews.llvm.org/D106328
_
wallace added inline comments.
Comment at: lldb/source/Commands/Options.td:1071
+Desc<"For each instruction, print the corresponding timestamp counter if
available.">;
}
clayborg wrote:
> You mentioned "--psb_period" in your description, but that isn't he
wallace updated this revision to Diff 360265.
wallace added a comment.
address comments + add tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106328/new/
https://reviews.llvm.org/D106328
Files:
lldb/docs/lldb-gdb-remote.txt
lldb/include/ll
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: JDevlieghere.
Man cases of having variables named "tsc" or "m_tsc" when it might be clear to
have them named "enable_tsc" and "m_enable_tsc".
===
wallace created this revision.
Herald added a subscriber: dang.
wallace updated this revision to Diff 359972.
wallace added a comment.
wallace updated this revision to Diff 359973.
wallace retitled this revision from "[intel pt] Add TSC timestamps" to
"[trace][intel pt] Add TSC timestamps".
wallac