kimanh added a comment.
Thanks for the review! Landing now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106270/new/
https://reviews.llvm.org/D106270
___
lldb-commits mailing list
lldb-commits@lists.llv
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0dda5425318a: [DWARF5] Fix offset check when using
.debug_names (authored by kimanh).
Changed prior to commit:
https://reviews.llvm.org/D106270?vs
jankratochvil accepted this revision.
jankratochvil added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/find-variable-file.cpp:34
+// RUN: %clang -c -o %t-2.o --target=x86_64-pc-linux -gdwarf-5 -gsplit-dwarf
-
kimanh added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3024
-m_index->GetGlobalVariables(
-dwarf_cu->GetNonSkeletonUnit(), [&](DWARFDIE die) {
- VariableSP var_sp(
shafik wrote:
> So is
shafik added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3024
-m_index->GetGlobalVariables(
-dwarf_cu->GetNonSkeletonUnit(), [&](DWARFDIE die) {
- VariableSP var_sp(
So is the problem that
kimanh added a comment.
Ping on this thread, any comment/guidance on this would help us a lot!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106270/new/
https://reviews.llvm.org/D106270
___
lldb-commits
kimanh added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:82
+ const DWARFUnit &non_skeleton_cu = cu.GetNonSkeletonUnit();
DWARFMappedHash::DIEInfoArray hash_data;
JDevlieghere wrote:
> I assume the `const` of the `D
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:82
+ const DWARFUnit &non_skeleton_cu = cu.GetNonSkeletonUnit();
DWARFMappedHash::DIEInfoArray hash_data;
I assume the `const` of the `DWARFUnit` is bei
kimanh created this revision.
Herald added a subscriber: arphaman.
kimanh added a subscriber: pfaffe.
kimanh edited the summary of this revision.
kimanh added a reviewer: labath.
kimanh published this revision for review.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
When
