[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

2021-07-19 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b54b1cdafbc: [lldb] Make WatchpointList iterable (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

2021-07-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: lldb/include/lldb/Breakpoint/WatchpointList.h:193 + WatchpointIterable Watchpoints() const { +return WatchpointIterable(m_watchpo

[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

2021-07-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/include/lldb/Breakpoint/WatchpointList.h:193 + WatchpointIterable Watchpoints() const { +return WatchpointIterable(m_watchpoints, m_mutex); NB: I needed to make a `const` variant since it's used in some `const

[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

2021-07-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: JDevlieghere, jingham. mgorny requested review of this revision. Based on de448c0a9e5088979526e2e67152fe547ae4ccf0 . https://reviews.llvm.org/D106263 Files: lldb/include